Skip to content

chore/handle numcodecs codecs #3376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Aug 13, 2025

This PR brings in all the codecs defined in numcodecs.zarr3. After this PR is merged, we can safely replace the numcodecs.zarr3 module with reexports from zarr python, or remove numcodecs.zarr3 entirely, thereby fixing our circular dependency problem.

This PR also changes the default config to ensure that the locally-defined codecs take priority over the same codec found in the numcodecs registry.

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Aug 13, 2025
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 96.85864% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.60%. Comparing base (c21d1f9) to head (b6b2260).

Files with missing lines Patch % Lines
src/zarr/codecs/_numcodecs.py 96.85% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3376      +/-   ##
==========================================
+ Coverage   94.55%   94.60%   +0.04%     
==========================================
  Files          79       80       +1     
  Lines        9448     9639     +191     
==========================================
+ Hits         8934     9119     +185     
- Misses        514      520       +6     
Files with missing lines Coverage Δ
src/zarr/core/config.py 83.33% <ø> (ø)
src/zarr/registry.py 88.81% <ø> (ø)
src/zarr/codecs/_numcodecs.py 96.85% <96.85%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant